Fixes for GZDoom >= 4.11.1 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Functions cannot directly return a multi-return function; these were apparently silently broken since the beginning, and GZDoom has since opted to error these out since GZDoom 4.11.1. The fix for this to multi-assign some local variables, and then return those instead. ZDoom/gzdoom#1892 - Replace some deprecated string/character functions. - Be explicit with uints, as the engine is now more strict regarding those. - "default" is a reserved ZScript keyword, change all instances of those to "def". - For non-empty-string comparisons, explicitly use the .Length() function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GZDoom 4.11.1 introduced some API breakage that made INIFile not compile. Please see the commit messages for more details.
(Addendum: in the commit messages, I erroneously refered to GZDoom 4.13.2 instead of GZDoom 4.11.1, as that was the engine version I was doing testing with. Technically, the actual API breakage occurred at GZDoom 4.11.1.)