Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type definitions? #333

Closed
mayank99 opened this issue Jan 13, 2023 · 4 comments · Fixed by #335
Closed

type definitions? #333

mayank99 opened this issue Jan 13, 2023 · 4 comments · Fixed by #335

Comments

@mayank99
Copy link
Contributor

when using the JS api:

  • there is no autocomplete for any of the props
  • importing in a .ts/.tsx file results in an error


i can contribute by either adding .d.ts files or by converting the codebase to all .ts

@mayank99
Copy link
Contributor Author

searching for open PRs, i found #223 and #225. i'll have a look at those and see if i can help with either or start from scratch

@argyleink
Copy link
Owner

autocomplete would def be nice, you've seen the other PRs, def the highest demanded feature missing from OP. thanks for throwin your hat in the ring to add it 🙂

importing in a .ts/.tsx file results in an error

can i learn more about this? working fine here?

test with this:

import colors from 'open-props/src/colors';
console.log(colors);

@mayank99
Copy link
Contributor Author

importing in a .ts/.tsx file results in an error

can i learn more about this? working fine here?

i see the same error in that example.

test with this:

import colors from 'open-props/src/colors';
console.log(colors);

i should also clarify that TS errors are nonblocking, just annoying - they do not make the actual build fail (unless running tsc along with the build) and can also be ts-ignored easily.

@argyleink
Copy link
Owner

ohh i see, the TS error, i thought the module was failing to import. ok, much less severe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants