-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TS support, cleans up modules #335
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Visit the preview URL for this PR (updated for commit 6505111): https://open-props--pr335-ts-autocomplete-j2g6ul5x.web.app (expires Tue, 31 Jan 2023 01:41:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 32524ac481f54edda55dc959fa4614cf1acc8c11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so now there will be typings for the default export from root, but not for any additional paths. is the goal to stop here or to allow a separate PR to generate those additional DTS files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've got nothing to add beyond @mayank99's comment #335 (comment)
LGTM! 👍
i was going to stop here, but it's not much more effort to produce individual |
alright y'all, i'll merge this tomorrow if we're feelin good about it. thanks for everyones help and effort! |
oh! or i need to figure out why the test failed first 🙂 |
Co-authored-by: Mayank <[email protected]> Co-authored-by: Howard Chiam <[email protected]>
super glad y'all're makin suggestions so we can collab on this PR 🙂 |
yo, you said tomorrow. i was just in the process of testing this with no worries, i'll test with actual 1.5.4 |
ah, sorry! i did. it just seemed ready and done. i updated https://stackblitz.com/edit/react-vanillaextract-openprops to latest and typeahead was there. how'd it go for you? all good? new gitignore got em all? |
fixes #333
microbundle wasnt building friendly files, making them hard to infer types from and impossible for authors to read. this drastically simplifies the build output for js modules while also adding a
.ts
file and.d.ts
typings file.preview of
open-props.ts
:preview of
open-props.d.ts
:thoughts @mayank99 or @hchiam?
no new deps, no invasive or fancy ts; just an easier to infer dist file for TS to grab