color-scheme adaptive fade-in/out-bloom #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hchiam
commented
Aug 16, 2022
There was a problem hiding this comment.
Ready for review. Hopefully close to what you had in mind, @argyleink:
Quick reference/reminder of how all these "bloom fades" started:
https://twitter.com/shuding_/status/1552438750470340610?s=20&t=95DjzncWa9CBSwEJkLBCbQ
I liked how there was contrast between the "flash of light" with the background in dark mode, but it might look out of place if we do the opposite (i.e. "darkness" amidst light background) in light mode. So instead of being asymmetrical/opinionated by treating dark mode differently from light mode ("flash of light" in dark mode but smoothly fade in light mode), I went with treating both similarly (smoothly fade in dark mode and smoothly fade in light mode). Thoughts?
argyleink
approved these changes
Aug 16, 2022
kelvindecosta
pushed a commit
to kelvindecosta/open-props
that referenced
this pull request
Nov 16, 2022
* color-scheme adaptive fade-in/out-bloom * update test (2x2=4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st draft follow-up to #260 (comment)