-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: include color helper #355
Conversation
Run & review this pull request in StackBlitz Codeflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Can you update a style too, so it aligns better on desktop? Here's what needs changed.
footer dl > div {
place-self: start center;
}
All done. Learned something new today, because this is the first time I'm seeing this particular CSS property — Thank you for the opportunity, @argyleink! |
docsite/index.css
Outdated
footer dl > div { | ||
place-self: start center; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change it here instead please =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a guess about this too. I'll change it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty! 💯
🫡 |
* chore: include color helper * chore: adjust layout * minor
* chore: include color helper * chore: adjust layout * minor
This reverts commit bd493f6.
#354
Hi @argyleink, kindly take a look.