-
Notifications
You must be signed in to change notification settings - Fork 103
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Strikethrough: fix exponential backtracking
A long sequence of backslashes inside a strikethrough could confuse the strikethrough regex into exponential backtracking, causing a potential ReDoS vulnerability. This commit updates the strikethrough regex to only accept a backslash if it is preceding an escaped character, as other rules handle backslashes. Updates to version 0.7.3 to publish this fix. Thanks to @pwntester and the [GitHub Security Lab team](https://securitylab.github.com/) for finding this vulnerability! Test plan: 1. `make test` * verify the new strikethrough backtracking test passes * verify all the prior tests pass
- Loading branch information
1 parent
7931523
commit 7d9a3cc
Showing
6 changed files
with
15 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters