Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/website: fix favicon and upgrade docusaurus #546

Merged
merged 2 commits into from
Feb 3, 2022
Merged

doc/website: fix favicon and upgrade docusaurus #546

merged 2 commits into from
Feb 3, 2022

Conversation

rotemtam
Copy link
Member

@rotemtam rotemtam commented Feb 3, 2022

this PR

  1. uses normal favicon on /static root - browsers should auto detect /favicon.ico.
  2. removes yarn from build - we're using npm
  3. upgrades to docusaurus 2.0.15

@rotemtam rotemtam merged commit 48cb560 into master Feb 3, 2022
@rotemtam rotemtam deleted the transparent-favicon branch February 3, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonidavidson yonidavidson yonidavidson approved these changes

@elad-n elad-n elad-n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rotemtam @yonidavidson @elad-n