sql/mysql: support for auto_increment attribute #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8m
commented
Feb 12, 2022
sql/mysql/diff.go
Outdated
Comment on lines
232
to
240
| // Ignore if the AUTO_INCREMENT attribute was dropped from the desired schema. | ||
| case fromHas && !toHas: | ||
| // The AUTO_INCREMENT exists in the desired schema, and may not exists in the inspected one. | ||
| // This can happen because older versions of MySQL (< 8.0) stored the AUTO_INCREMENT counter | ||
| // in main memory (not persistent), and the value is reset on process restart for empty tables. | ||
| case toHas && fromA.V < toA.V: | ||
| // Suggest a diff only if the desired value is greater than the inspected one, | ||
| // because this attribute cannot be maintained in users schema and used to set | ||
| // up only the initial value. |
There was a problem hiding this comment.
Verbose comments, but prefer to keep them for future maintainers as this info exists only in my head atm.
Also, fix minor diff issue in AUTO_INCREMENT migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL support for #517. PostgreSQL and SQLite will be added in future PRs.