Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/action: change defualt listen address to work on all cases #627

Merged
merged 2 commits into from
Mar 6, 2022
Merged

cmd/action: change defualt listen address to work on all cases #627

merged 2 commits into from
Mar 6, 2022

Conversation

zeevmoney
Copy link
Contributor

No description provided.

@zeevmoney zeevmoney requested review from rotemtam and a8m March 6, 2022 09:57
rotemtam
rotemtam approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@rotemtam rotemtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI broken. Also, I think there were tests for this?
Merge after fixing

@zeevmoney zeevmoney merged commit 0f0035b into master Mar 6, 2022
@zeevmoney zeevmoney deleted the fix-listen-addr branch March 6, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotemtam rotemtam rotemtam approved these changes

@a8m a8m Awaiting requested review from a8m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeevmoney @rotemtam