Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta.tests): Adding the test case to verify BGP advertised community #501

Merged
merged 6 commits into from
Feb 12, 2024
Merged

feat(anta.tests): Adding the test case to verify BGP advertised community #501

merged 6 commits into from
Feb 12, 2024

Conversation

MaheshGSLAB
Copy link
Collaborator

Description

Add the test case to verify the BGP advertised community.

Fixes #498

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@MaheshGSLAB MaheshGSLAB self-assigned this Dec 21, 2023
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review December 21, 2023 06:22
@MaheshGSLAB MaheshGSLAB changed the title feat: Adding the test case to verify BGP advertised community feat(anta.tests)!: Adding the test case to verify BGP advertised community Jan 4, 2024
@gmuloc gmuloc changed the title feat(anta.tests)!: Adding the test case to verify BGP advertised community feat(anta.tests): Adding the test case to verify BGP advertised community Jan 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@MaheshGSLAB MaheshGSLAB requested a review from gmuloc January 10, 2024 05:42
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

carl-baillargeon
carl-baillargeon approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@titom73 titom73 self-requested a review February 7, 2024 14:50
@titom73 titom73 added validated PR validated, waiting for conflict resolution or PR merge party and removed one-more-review labels Feb 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@titom73 titom73 merged commit 1814b5d into aristanetworks:main Feb 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@MaheshGSLAB MaheshGSLAB

Labels
rn: feat(anta.tests) validated PR validated, waiting for conflict resolution or PR merge party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the test case to verify the BGP neighbor community
4 participants
@MaheshGSLAB @titom73 @carl-baillargeon @gmuloc