Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta.tests): Add IS-IS tests collection #643

Merged
merged 21 commits into from
Apr 29, 2024
Merged

feat(anta.tests): Add IS-IS tests collection #643

merged 21 commits into from
Apr 29, 2024

Conversation

titom73
Copy link
Collaborator

@titom73 titom73 commented Apr 21, 2024 •
edited
Loading

Description

Implement new set of tests to cover IS-IS and Segment Routing

IS-IS tests

  • Check that all ISIS neighbors are UP
  • Number of peers per interface
  • List of passive/non-passive interfaces

Related to #636

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@titom73 titom73 added this to the v1.1.0 milestone Apr 21, 2024
@titom73 titom73 self-assigned this Apr 21, 2024
@titom73 titom73 marked this pull request as draft April 21, 2024 11:04
@titom73 titom73 requested review from mtache and gmuloc April 26, 2024 06:36
@titom73 titom73 marked this pull request as ready for review April 26, 2024 06:36
gmuloc
gmuloc reviewed Apr 26, 2024
View reviewed changes
anta/tests/routing/isis.py Outdated Show resolved Hide resolved
anta/tests/routing/isis.py Outdated Show resolved Hide resolved
anta/tests/routing/isis.py Outdated Show resolved Hide resolved
anta/tests/routing/isis.py Outdated Show resolved Hide resolved
anta/tests/routing/isis.py Outdated Show resolved Hide resolved
anta/tests/routing/isis.py Outdated Show resolved Hide resolved
anta/tests/routing/isis.py Outdated Show resolved Hide resolved
anta/tests/routing/isis.py Outdated Show resolved Hide resolved
anta/tests/routing/isis.py Outdated Show resolved Hide resolved
anta/tests/routing/isis.py Outdated Show resolved Hide resolved
titom73 and others added 10 commits April 26, 2024 10:41
@titom73 @gmuloc
Update anta/tests/routing/isis.py
01de5e8 
Co-authored-by: Guillaume Mulocher <[email protected]>
@titom73 @gmuloc
Update anta/tests/routing/isis.py
e3c3394 
Co-authored-by: Guillaume Mulocher <[email protected]>
@titom73 @gmuloc
Update anta/tests/routing/isis.py
45050de 
Co-authored-by: Guillaume Mulocher <[email protected]>
@titom73 @gmuloc
Update anta/tests/routing/isis.py
c0c08f2 
Co-authored-by: Guillaume Mulocher <[email protected]>
@titom73 @gmuloc
Update anta/tests/routing/isis.py
bec6187 
Co-authored-by: Guillaume Mulocher <[email protected]>
@titom73 @gmuloc
Update anta/tests/routing/isis.py
b1ae943 
Co-authored-by: Guillaume Mulocher <[email protected]>
@titom73
fix(anta.tests): Update as per review
2fce278
@titom73
fix(anta.tests): Update as per review
03579e5
@titom73 @gmuloc
Update anta/tests/routing/isis.py
d7e373b 
Co-authored-by: Guillaume Mulocher <[email protected]>
@titom73
fix(anta.tests): Update as per review
d3c2ce8
@titom73 titom73 requested a review from gmuloc April 26, 2024 13:50
@titom73 titom73 merged commit 4ef2a23 into aristanetworks:main Apr 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtache mtache Awaiting requested review from mtache

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@titom73 titom73

Labels
network-tests rn: feat(anta.tests)
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@titom73 @gmuloc @mtache