Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta.tests): Fix VerifySSHStatus to support 4.32 text output #874

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

carl-baillargeon
Copy link
Contributor

Description

EOS 4.32 changed the text output of show management ssh, breaking our existing logic. New logic handles both pre and post 4.32 outputs.

Fixes # (issue id)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

codspeed-hq bot commented Oct 10, 2024

CodSpeed Performance Report

Merging #874 will not alter performance

Comparing carl-baillargeon:fix/verify_ssh_status (1f0fa4b) with main (86e8602)

Summary

✅ 8 untouched benchmarks

Copy link

@gmuloc
Copy link
Collaborator

gmuloc commented Oct 10, 2024

VerifySSHStatus test should be augmented to support a different VRF and an expected state in the future (with defaults being disabled / default to be backward compatib;e)

@gmuloc gmuloc merged commit 387c281 into aristanetworks:main Oct 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants