Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta): Mcs client mounts #898

Merged
merged 19 commits into from
Nov 12, 2024
Merged

Conversation

sarunac
Copy link
Contributor

@sarunac sarunac commented Oct 24, 2024

Description

Anta Tests to verify if management cvx mounts for service mcs is in healthy state = mountStateMountComplete

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

codspeed-hq bot commented Oct 24, 2024

CodSpeed Performance Report

Merging #898 will not alter performance

Comparing sarunac:mcsClientMounts (7da52f0) with main (5f65676)

Summary

✅ 8 untouched benchmarks

anta/tests/configuration.py Outdated Show resolved Hide resolved
anta/tests/configuration.py Outdated Show resolved Hide resolved
anta/tests/configuration.py Outdated Show resolved Hide resolved
anta/tests/configuration.py Outdated Show resolved Hide resolved
anta/tests/configuration.py Outdated Show resolved Hide resolved
anta/tests/configuration.py Outdated Show resolved Hide resolved
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

sarunac and others added 3 commits November 7, 2024 11:51
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need to add a new section to the doc under docs/api/test.cvx.md - you can copy paste any of the other and check (or if you want we can schedule a call to do it together!)

anta/tests/cvx.py Outdated Show resolved Hide resolved
anta/tests/cvx.py Outdated Show resolved Hide resolved
anta/tests/cvx.py Outdated Show resolved Hide resolved
@sarunac
Copy link
Contributor Author

sarunac commented Nov 8, 2024

will need to add a new section to the doc under docs/api/test.cvx.md - you can copy paste any of the other and check (or if you want we can schedule a call to do it together!)

done.

@gmuloc gmuloc merged commit 2931fe1 into aristanetworks:main Nov 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants