Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(anta.tests): Updated failure msgs to avoid use of ; #936

Merged
merged 5 commits into from
Nov 28, 2024
Merged

refactor(anta.tests): Updated failure msgs to avoid use of ; #936

merged 5 commits into from
Nov 28, 2024

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Fix the failure messages:

  • VerifyReachability
  • VerifyInterfacesStatus
  • VerifyNTPAssociations
  • VerifyDNSServers
  • VerifyLLDPNeighbors
  • BGP part-1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@vitthalmagadum
Updated failure msgs: VerifyReachability, VerifyInterfacesStatus, Ver…
44a6945 
…ifyNTPAssociations, VerifyDNSServers, VerifyLLDPNeighbors, BGP Part-1
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 26, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #936 will not alter performance

Comparing vitthalmagadum:fix/failure_msgs (cc1bb0d) with main (2de0f5a)

Summary

✅ 8 untouched benchmarks

@vitthalmagadum vitthalmagadum changed the title fix(anta.tests): Updated failure msgs to avoid use of , & ; fix(anta.tests): Updated failure msgs to avoid use of ; Nov 28, 2024
gmuloc
gmuloc approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vitthalmagadum

@gmuloc gmuloc changed the title fix(anta.tests): Updated failure msgs to avoid use of ; refactor(anta.tests): Updated failure msgs to avoid use of ; Nov 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gmuloc gmuloc merged commit 6b6d8e1 into aristanetworks:main Nov 28, 2024
23 checks passed
geetanjalimanegslab pushed a commit to geetanjalimanegslab/anta that referenced this pull request Dec 10, 2024
@vitthalmagadum @gmuloc @geetanjalimanegslab
refactor(anta.tests): Updated failure msgs to avoid use of ; (arist…
7205459 
…anetworks#936)

* Updated failure msgs: VerifyReachability, VerifyInterfacesStatus, VerifyNTPAssociations, VerifyDNSServers, VerifyLLDPNeighbors, BGP Part-1

* Updated unit tests for format_data utility

* Reverting changes related to comma

* reverting chnages from tools and test tools

---------

Co-authored-by: Guillaume Mulocher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@carl-baillargeon carl-baillargeon Awaiting requested review from carl-baillargeon

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: refactor(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitthalmagadum @gmuloc