Feat(eos_designs): Optional dedicated MLAG peer group for VRFs

[Vibhu-gslab]

Change Summary

Currently MLAG-IPv4-UNDERLAY-PEER is used for the iBGP session between MLAG pairs in the underlay and overlay. This approach can be misleading due to the use of UNDERLAY word in the BGP peer group name.

The following is an example of the configuration that AVD generates today

router bgp xxxx 
   neighbor MLAG-IPv4-UNDERLAY-PEER peer group
   neighbor MLAG-IPv4-UNDERLAY-PEER remote-as 65000.1
   neighbor MLAG-IPv4-UNDERLAY-PEER next-hop-self
   neighbor MLAG-IPv4-UNDERLAY-PEER description DC1-CL2
   neighbor MLAG-IPv4-UNDERLAY-PEER password 7 xxxx
   neighbor MLAG-IPv4-UNDERLAY-PEER send-community
   neighbor MLAG-IPv4-UNDERLAY-PEER maximum-routes 12000
   neighbor MLAG-IPv4-UNDERLAY-PEER route-map RM-MLAG-PEER-IN in

   address-family ipv4
      neighbor MLAG-IPv4-UNDERLAY-PEER activate

   vrf BLUE
      rd 192.168.100.1:1002
      route-target import evpn 1002:1002
      route-target export evpn 1002:1002
      router-id 192.168.100.1
      neighbor 172.16.1.1 peer group MLAG-IPv4-UNDERLAY-PEER
      redistribute connected

Related Issue(s)

Fixes #4826
Fixes #4916

Component(s) name

arista.avd.eos_designs

Proposed changes

Plan for this issue to be non-breaking:
1/ introduce a new knob to use_separate_mlag_peer_group_for_overlay: with a default of false.
2/ add a peer_group in bgp_peer_groups for MLAG overlay to be used when the toggle from 1/ is true

How to test

Molecule testing

Checklist

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4881
# Activate the virtual environment
source test-avd-pr-4881/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@mlag_peer_group_4826#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,mlag_peer_group_4826 --force
# Optional: Install AVD examples
cd test-avd-pr-4881
ansible-playbook arista.avd.install_examples

[gmuloc]

@ksantos01 can you test the PR and see if that works for you?

[ClausHolbechArista]

@ksantos01 do you have time to test this PR this week? Then we can get it into 5.2 releasing on Friday.

[ksantos01]

I have tested it and it works for my use case

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud