Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug state_graph #630

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Debug state_graph #630

merged 1 commit into from
Feb 20, 2024

Conversation

Sichao25
Copy link
Collaborator

@Sichao25 Sichao25 commented Dec 5, 2023

Bug description: The transition probability sum for some cell types is much larger than 1.

Proposed solution: Normalize the graph in state_graph() based on the number of target cell types for each trajectory found.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1e8ffe4) 22.54% compared to head (d60f1a3) 22.17%.
Report is 166 commits behind head on master.

Files Patch % Lines
dynamo/prediction/state_graph.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
- Coverage   22.54%   22.17%   -0.38%     
==========================================
  Files         166      166              
  Lines       27362    28032     +670     
==========================================
+ Hits         6168     6215      +47     
- Misses      21194    21817     +623     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sichao25 Sichao25 marked this pull request as ready for review December 7, 2023 15:59
@Xiaojieqiu Xiaojieqiu merged commit 510be14 into aristoteleo:master Feb 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants