This repository has been archived by the owner on May 30, 2023. It is now read-only.
Cast response body to string in binary mode. #13452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why Latin-1 instead of UTF-8? |
|
@JamesMGreene because it's binary data. UTF-8 may double the output data. |
|
Does the |
|
@JamesMGreene nop, it just converts (constructs) a QString. |
|
LGTM, although we probably need some sanity tests for that. |
|
I wonder if this is why the existing binary-response test in webserver-spec.js is xfailed.
|
|
@zackw unfortunately no, I tried to run your sample with this patch, and it's still failing :( |
QVariantHelper expects body to be the same type as before conversion. If target type doesn't match the source type, QVariantHelper will return 0. We can't convert in this way: QString > QVariant -> QByteArray Instead we must use the following way: QString > QVariant -> QString Fixes: ariya#13026
vitallium
force-pushed
the
fix-webserver-binary-mode
branch
from
6b9b2bf to
deb7afa
Compare
|
|
Landed in b1ed678 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QVariantHelper expects body to be the same type as before conversion.
If target type doesn't match the source type, QVariantHelper will return 0.
We can't convert in this way:
QString -> QVariant -> QByteArrayInstead we must use the following way:
QString -> QVariant -> QStringFixes: #13026