kble_gsをWebSocketのgracefulな終了に対応させる #133
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
0.7.0-beta.5 の cargo package の実験後にマージします |
|
v0.7.0 に乗せ忘れたので v1.0.0 に入れます……（申し訳ない） |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
kble_gsのWebSocket接続がgracefulに終了した場合、uplink側はコマンド待ちで終了せず、downlink側はエラーを吐かないため、（次のコマンドが送られてきてsendに失敗するまで）joinから抜けられない
したがってjoinをselectに変更する
また、終了時に
sink.clone()することでWebSocketの接続をgracefulに終了する変更の意図や背景
発端となる Issue