Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary field: implement Bf1 #909

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tcoratger
Copy link
Contributor

Description

@Pratyush Here is my proposal to implement the first element of the binary tower, the basic binary field. The inspiration is taken from Binius repo: https://gitlab.com/IrreducibleOSS/binius

pub struct Bf1(U1);
pub struct Bf2(U2);
pub struct Bf4(U4);
pub struct Bf8(u8);
pub struct Bf16(u16);
pub struct Bf32(u32);
pub struct Bf64(u64);
pub struct Bf128(u128);
  • I haven't made a macro yet because this is a first proposal with a single field. At first I think we can make several small basic PRs without a macro and see if at the end we can refactor with a macro but I don't think it's necessarily useful right away. Also for the Bf128, I think we can use the polyval base which seems a little more efficient (to test: https://github.com/RustCrypto/universal-hashes/tree/master/polyval) and so maybe it won't fit in the macro either, we'll see.

  • @Pratyush Please provide feedback so that we can merge quite fast and iterate on that with small issues.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@tcoratger tcoratger requested review from a team as code owners December 20, 2024 00:11
@tcoratger tcoratger requested review from Pratyush, mmagician and tyshko-rostyslav and removed request for a team December 20, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant