This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 103
Sync with the recent changes in ark-algebra on pairing and testing #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I decided to do a force merge. |
Ok. I actually cannot do a force merge. @Pratyush can you do so? The problem is that the no_std test appears to be surprising. |
Hm there's a bunch of changes here; what's the main change? |
Originally it was just to fix a typo, now I think it is to merge with the refactoring... I know why those errors show up, and I am fixing them now... |
Renamed. |
Pratyush
reviewed
Sep 2, 2022
Pratyush
previously requested changes
Sep 2, 2022
I left a bunch of requests re: the LICENSE files |
Pratyush
reviewed
Sep 2, 2022
Pratyush
reviewed
Sep 2, 2022
Thanks for handling this! Small note, seems like the |
Pratyush
reviewed
Sep 2, 2022
Now depending on arkworks-rs/algebra#465 |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a followup of #114. Simon Masson @simonmasson pointed out that a positive d, which in our formula should be negative, needs to be changed as well.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Files changed
in the Github PR explorerN/A:
Pending
section inCHANGELOG.md