Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Sync with the recent changes in ark-algebra on pairing and testing #116

Merged
merged 14 commits into from
Sep 2, 2022

Conversation

weikengchen
Copy link
Member

Description

This is a followup of #114. Simon Masson @simonmasson pointed out that a positive d, which in our formula should be negative, needs to be changed as well.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Updated relevant documentation in the code
  • Re-reviewed Files changed in the Github PR explorer

N/A:

  • Wrote unit tests
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md

@weikengchen weikengchen changed the title Fix another typo in the Jubjub curve comment Fix a typo in Jubjub code and refactor for ark-algebra Sep 2, 2022
@weikengchen
Copy link
Member Author

I decided to do a force merge.

@weikengchen
Copy link
Member Author

Ok. I actually cannot do a force merge. @Pratyush can you do so? The problem is that the no_std test appears to be surprising.

@Pratyush
Copy link
Member

Pratyush commented Sep 2, 2022

Hm there's a bunch of changes here; what's the main change?

@weikengchen
Copy link
Member Author

Originally it was just to fix a typo, now I think it is to merge with the refactoring...

I know why those errors show up, and I am fixing them now...

@weikengchen weikengchen changed the title Fix a typo in Jubjub code and refactor for ark-algebra Sync with the recent changes in ark-algebra on pairing and testing Sep 2, 2022
@weikengchen
Copy link
Member Author

Renamed.

@Pratyush
Copy link
Member

Pratyush commented Sep 2, 2022

I left a bunch of requests re: the LICENSE files

@Pratyush
Copy link
Member

Pratyush commented Sep 2, 2022

Thanks for handling this!

Small note, seems like the mul_by_a change hasn't propagated to the bandersnatch crate.

@weikengchen
Copy link
Member Author

Now depending on arkworks-rs/algebra#465

@weikengchen weikengchen merged commit 3c4c67f into master Sep 2, 2022
@weikengchen weikengchen deleted the jubjub-typo-2 branch September 2, 2022 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants