Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few more missing ids #262

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

nazli-stripe
Copy link
Contributor

Adds some of the remaining missing ids. Wasn't able to find anything for CheckoutSessionItemId, are those Line Items? https://stripe.com/docs/api/checkout/sessions/line_items

@nazli-stripe nazli-stripe force-pushed the nazli/missing-obj-ids branch from 7d05cf1 to 103155b Compare August 19, 2022 21:35
@arlyon
Copy link
Owner

arlyon commented Aug 21, 2022

Hey, thanks for this! We had a CI issue (fixed in PR #264) could you please rebase and I'll merge this asap :)

@nazli-stripe nazli-stripe force-pushed the nazli/missing-obj-ids branch from 103155b to e55941e Compare August 21, 2022 15:44
@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #262 (0cbbd08) into master (837c3e3) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #262   +/-   ##
======================================
  Coverage    5.41%   5.41%           
======================================
  Files         150     150           
  Lines       14397   14397           
======================================
  Hits          780     780           
  Misses      13617   13617           
Impacted Files Coverage Δ
src/ids.rs 36.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nazli-stripe nazli-stripe force-pushed the nazli/missing-obj-ids branch from 7724f64 to 670f594 Compare August 21, 2022 16:14
@nazli-stripe nazli-stripe force-pushed the nazli/missing-obj-ids branch from 670f594 to 0cbbd08 Compare August 21, 2022 16:32
@arlyon arlyon merged commit d208423 into arlyon:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants