Corrected CancelSubscription fields for current Stripe API version. #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected fields for current Stripe API version. - replaced `at_period_end` with `invoice_now` - added `cancellation_details` field - added `prorate` field https://stripe.com/docs/api/subscriptions/cancel
|
Should we include a fix for #419 in this since you are doing work around |
|
I don't mind merging this now and opening a new PR. Thanks! We are waiting on a fix in #426 to fix CI and then I will ask you to rebase. |
Merged
This was referenced Feb 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #402. Accidentally closed. Sorry!
Corrected CancelSubscription fields for current Stripe API version.
A fix for #394
https://stripe.com/docs/api/subscriptions/cancel
According to the current Stripe API in the link above, there is no "reason" field within cancellation_details any longer. This also aligns with my testing where it did not recognize the parameter.
Consider removing this struct in future versions. For now, users can leave this as None.
at_period_endwithinvoice_nowcancellation_detailsfieldproratefieldChecklist
cargo make fmt