Skip to content

Commit

Permalink
Update ingesters to all use Failover subscription mode (#3873)
Browse files Browse the repository at this point in the history
The scheduler ingester already uses Failover, swapping all to Failover so we are consistent

This will also allow us to get good latency metrics of processing delay by partition from pulsar:
 - When we use KeyShared, we may not process a partition strictly in order, so the metric isn't that useful

Signed-off-by: JamesMurkin <[email protected]>
  • Loading branch information
JamesMurkin authored Aug 13, 2024
1 parent fcf7fe6 commit b8fdf3d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion internal/eventingester/ingester.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func Run(config *configuration.EventIngesterConfiguration) {
config.SubscriptionName,
config.BatchSize,
config.BatchDuration,
pulsar.KeyShared,
pulsar.Failover,
converter,
eventDb,
config.MetricsPort,
Expand Down
2 changes: 1 addition & 1 deletion internal/lookoutingesterv2/ingester.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func Run(config *configuration.LookoutIngesterV2Configuration) {
config.SubscriptionName,
config.BatchSize,
config.BatchDuration,
pulsar.KeyShared,
pulsar.Failover,
converter,
lookoutDb,
config.MetricsPort,
Expand Down

0 comments on commit b8fdf3d

Please sign in to comment.