Relax Patch Release Regex #3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously patch release branches had to match the regex
^patch/v[0-9]+\.[0-9]+\.[0-9]+-patch[0-9]+$which essentially meant a separate release branch for each patch release (patch/v0.9.0-patch1,patch/v0.9.0-patch2etc). We've now relaxed this to be^patch/v[0-9]+\.[0-9]+\.[0-9]+.*which means that we can just create a single release release branch for a given release (e.g.patch/v0.9.0) and then create as many patches off it as we want. Note that the release tag regex hasn't changed and so the tag itself must contain the patch version.Note that this regex is a security control as it ensures we can only created official releases from protected branches. This change is safe because all branches under
patch/*are protected.