Queue cordoning in Armadactl (#187) #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Plumbing queue cordoning into armadactl * Making armadactl cordoning commands more intuitive, some formatting changes * Formatting * Making queue get more intuitive * Correcting comments and error messages * Removing single queue cordoning code in favour of cobra alias. Adding only-cordoned flag when fetching queues * Removing unused methods * Removing method prefix from error messages * Fixing import order
JamesMurkin
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plumbing queue cordoning into armadactl
Making armadactl cordoning commands more intuitive, some formatting changes
Formatting
Making queue get more intuitive
Correcting comments and error messages
Removing single queue cordoning code in favour of cobra alias. Adding only-cordoned flag when fetching queues
Removing unused methods
Removing method prefix from error messages
Fixing import order
Summary of changes:
cordonanduncordoncommands to armadactlqueueandqueuesresourcesqueuesvia armadactl