Make the executor close LeaseJobRuns stream #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
d80tb7
reviewed
Sep 5, 2024
| } | ||
| } | ||
|
|
||
| err = closeStream(stream) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
couldn't we just log a warning here? We've got all the information we need so do we need to propagate the error?
Signed-off-by: JamesMurkin <[email protected]>
…esearch/armada into executor_close_stream_better
d80tb7
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that we properly wait for the EOF on the stream, which indicates the stream has closed successfully
In addition I've made the stream handling simpler: