Filter out invalid JST in ReconcileDifferences #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ma/fix-nil-state-transitions
Signed-off-by: Chris Martin <[email protected]>
JamesMurkin
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReconcileDifferences was generating invalid jobs state transitions containing a nil Job. The scheduler was filtering these out, however the metrics code wasn't, thus leading to panics when the metrics attempted to access the job.
Rather than make the metrics code also filter these out, I've modified ReconcileDifferences so that these are never returned in the first place. Ideally we would never even create such a transition, but that would be a bigger and more invasive change.