Disabling of leader-only cycle metrics when scheduler is follower #3949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rol of leader metrics (#226)
d80tb7
approved these changes
Sep 12, 2024
svc-gh-ghzonetrans-p
restored the
sendToGitHub/reset-scheduler-metrics-on-follower
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all of the scheduler's cycle metrics continue to be collected when the scheduler is in follower mode. This results in stale metrics. This change brings these metrics in line with the scheduler's state metrics, resetting and disabling the collection of these metrics when the scheduler is a follower, excluding the reconciliation cycle time metric which continues to be observed and collected.
This PR also consolidates the disabling/enabling of both state and cycle metrics under Disable/EnableLeaderMetrics.