Lookout Ingester DB Load Tester #4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a load test that which using the Lookout Ingester message conversion and database insertion code, allowing us to insert realistic event patterns into the database and measure comparative performance of changes to the database code.
MustafaI
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a load test that which using the Lookout Ingester message conversion and database insertion code, allowing us to insert realistic event patterns into the database and measure comparative performance of changes to the database code.
Only change to existing code to facilitate this is to the batcher, so it finishes batching more gracefully when the input channel is closed. This only impacts it's behaviour in the context of testing, as in normal use we don't expect the input channel to close outside of the whole service restarting where the unbatched messages would be unprocessed regardless.