Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Logging To Zerolog #4136

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

Switch Logging To Zerolog #4136

wants to merge 65 commits into from

Conversation

d80tb7
Copy link
Collaborator

@d80tb7 d80tb7 commented Jan 14, 2025

  • Define a New logging Abstraction in common/logging to allow creattion of Loggers or gloabl logging (e.g. log.Info()). This means that none of our code outside of the logging package depends on any logging implementation.
  • Define a zerolog implementation of the logging abstraction.
  • Updates the code to use the new logging abstraction.
  • Implements a prometheus hook which recreates https://github.com/weaveworks/promrus so that we get prometheus metrics about log levels. The metric name hasn't changed so this should be backwards compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants