Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix iostat error on MINIMAL #7454

Merged
merged 1 commit into from
Nov 9, 2024
Merged

fix iostat error on MINIMAL #7454

merged 1 commit into from
Nov 9, 2024

Conversation

EvilOlaf
Copy link
Member

@EvilOlaf EvilOlaf commented Nov 9, 2024

Description

MINIMAL do not have iostat so suppress the error occurring when doing armbianmonitor -u on such systems.
I am pretty sure there is a nicer way to implement this. So some wizard may come up with something better.

How Has This Been Tested?

  • do armbianmonitor -u on a minimal system and check if an error occurs

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

`MINIMAL` do not have `iostat` so suppress the error occurring when doing `armbianmonitor -u` on such systems.
@EvilOlaf EvilOlaf requested a review from a team as a code owner November 9, 2024 16:03
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review BSP Board Support Packages labels Nov 9, 2024
@EvilOlaf EvilOlaf changed the title fix iostat on MINIMAL fix iostat error on MINIMAL Nov 9, 2024
@EvilOlaf
Copy link
Member Author

EvilOlaf commented Nov 9, 2024

I have no idea why I sent that fix in the middle of a meeting. This bugged me forever....

Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, no need to do it nicer

@github-actions github-actions bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Nov 9, 2024
@igorpecovnik igorpecovnik merged commit fb261bb into main Nov 9, 2024
@igorpecovnik igorpecovnik deleted the fix-iostat-on-minimal branch November 9, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP Board Support Packages Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants