-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ST7796 kernel module (fbtft) #7543
feat: add ST7796 kernel module (fbtft) #7543
Conversation
Nice, the driver looks like ok, there's a typo though in the heading comment:
Anyway, this should be introduced for rockchip64 edge kernel (6.12) too, otherwise it will get cut off during next current kernel bump. |
Not sure I got this part. Now the patch file in 6.6 folder and 6.12 has a link to it. Do you mean it's pbetter to put a copy of the patch instead symlink? (Typo was fixed) |
83eb214
to
059919d
Compare
Add support for ST7796 based LCD module (connected via SPI interface). One of real device example is [MKS PI-TS35 display](https://github.com/makerbase-mks/MKS-TFT-Hardware/tree/master/MKS%20PI-TS35).
059919d
to
556333d
Compare
Ah sorry, didn't notice the symlink in 6.12 and 6.9 directories; Despite I see the symlink being done elsewhere, TBH I would discourage doing so: at one point in time, 6.6 kernel will be dismissed and its patch directory removed. Possible symlinks pointing to 6.6 patch in other patch archives (in your case 6.9 and 6.12) will break. I don't like the idea that removing the 6.6 patch archive directory may affect other patch archives. |
Done, symlinks were replaced by copies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patience, approved!
this commit is breaking git clone see workflow errors https://github.com/armbian/build/actions/runs/12216820229 |
How to fix it? Is it possible to reset master for -2 commits back and then reopen a PR? |
Oh wow. How this came to be is beyond me. So the first commit added symlinks, and the second one changed it's contents to a copy of the symlinked, but apparently failed to change the mode of the file; thus the patch contents (which is very large) is interpreted by git as the "symlink target" leading to "file name too long". Fact that GitHub hides the details makes it not easy at all. Was @redrathnure using Windows or core.symlinks=off to do this? To fix this we need force-push powers to |
Hmm, clean checkout failed ... need to figure out how to deal with this, before making more damages.
|
done. |
A version without symlinks magic: #7550 |
I apologize for the mess my suggestion caused 😔 |
No worries, we learned something new. |
Description
Add support for ST7796 based LCD module (connected via SPI interface). One of real device example is MKS PI-TS35 display.
How Has This Been Tested?
The changes was tested on MKS PI-TS35 display together with MKS-PI board as part of custom Armbian image. Touch screen uses an
ads7846
module.Checklist: