firstlogin: bring up wifi device before scanning #7803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Firstlogin on a minimal image is not able to configure and use wifi.
(Server and desktop images work OK, as they have NetworkManager installed.)
Scanning accesspoints requires an activated wifi device.
An unconfigured networkd does not activate it (only NetworkManager does so).
As a result, firstlogin fails to scan for APs and skips setting up timezone and locales.
Activating the wifi device using
ip link set ${WIFI_DEVICE} up
before scanning fixes this.(And can safely be done - there is no problem activating it multiple times, like it is the case with NetworkManager installed.)
How Has This Been Tested?
command failed: Network is down (-100)
Both images (with and without NetworkManager) were able to bring up and use wifi during armbian-firstlogin without any errors.
Checklist: