bug: jumping to menu item via numbers do not work when ChName is selected

[prokrypt]

Steps to reproduce:

• Press MENU
• Press 1 7 to get to ChName
• Numbers (and * and F) do nothing. It thinks a channel name is being inputted, maybe.

This probably has something to do with edit_index in menu.c. Either it's not being set to -1, or something is changing it.
A fast fix would be to add a check for gIsInSubMenu in each of the affected key functions, but that's not ideal and takes up precious bytes...

[prokrypt]

More interesting things:

• Press MENU
• Press 1 7
• Press MENU
• Press EXIT
• Numbers work to jump to other menu items
• Press 1 7 to get back to ChName
• Press MENU twice
• Press EXIT
• Numbers no longer work.

[prokrypt]

I fixed it by adding edit_index = -1; to app/menu.c, MENU_ShowCurrentSetting function, under case MENU_MEM_NAME:

uv-k5-firmware-custom/app/menu.c

Line 1007 in 15ff3d1

case MENU_MEM_NAME:

Not sure if that's the correct place, but it's the best I could do...

[prokrypt]

More changes: move edit_index = -1; from

uv-k5-firmware-custom/app/menu.c

Line 1557 in 15ff3d1

edit_index = -1;

to after/before

uv-k5-firmware-custom/app/menu.c

Line 1596 in 15ff3d1

gIsInSubMenu = false;

otherwise the same issue occurs when you keep pressing menu until the text input exits.

[prokrypt]

Fixed it with a change in one spot only:

uv-k5-firmware-custom/ui/menu.c

Line 746 in 15ff3d1

if (!gIsInSubMenu || edit_index < 0)

change if (!gIsInSubMenu || edit_index < 0)
to

if (!gIsInSubMenu)
	edit_index = -1;
if (edit_index < 0)

and edit_index = -1; can be removed in app/menu.c to save a few bytes.

[armel]

Ok, thank you. It will be fixed in the next release.