Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double beep for non-existent channel, changing the channel with the arrows while entering the digits #192

Closed
mrkusypl opened this issue Jul 17, 2024 · 2 comments

Comments

@mrkusypl
Copy link

The modified codes below is based on the previous fix (#175)

During use, I noticed that the existence of the channel is checked every time a digit is entered.

For example, suppose we have channel 35 stored, but channel 3 is empty. Entering the digit 3 will trigger a beep indicating that there is no channel 3 even though our intention is not to go to channel 3. The timeout is still in progress, so pressing 5 will go to channel 35 which exists. I have made the beep appear after the timeout has stopped (for one-digit and two-digit numbers). The problem does not appear with three-digit numbers, because there is no timeout there.

Modified code: 6820b0a

8mb.video-XBp-4Vm0hRt8.mp4

Also, I added that when changing the channel by entering digits, using the arrows during the timeout will change the channel relative to the channel entered by the digits (previously, using the arrows triggered a beep).

Modified code: 53d63d8

VID_20240709_033002.mp4

I also managed to save 8 bytes.

armel added a commit that referenced this issue Jul 17, 2024
@armel
Copy link
Owner

armel commented Jul 17, 2024

Hello,

Ok for the first improvement. It sounds good to me. I added it to the next release.
About the second one, I'm less interested.

Thank you 🙏🏻

Armel F4HWN.

@armel armel closed this as completed Jul 17, 2024
@armel
Copy link
Owner

armel commented Jul 18, 2024

Hello,

Please, take a look at issue #194 if you have time :) This is probably a regression bug due to your patch.

I understand that if you are on channel 50, switch to channel 120 and turn off the K5, you will return to channel 50 if you restart it. The problem seems to be only if you move on a channel > 100.

Regards,

F4HWN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants