feat(deploy): add Source Control Management context to api request #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started the github context retrieval
Source Control Management Context added to the deployment request under sourceControl
Changed the ScmContext and made and embedded struct githubScmc
cs-simental
force-pushed
the
feat/source_lineage
branch
from
d57cbcd to
a5b84c4
Compare
fieldju
reviewed
Aug 25, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
fieldju
dismissed
their stale review
I miss read somethings, sanity checking now
fieldju
reviewed
Aug 25, 2023
Taking into account the Env variables already being there when the test are run in github
mrampton
changed the title
fieldju
approved these changes
Aug 25, 2023
added missing property 'sourcecontrol: null'
Validate that env variables are not empty Validate that pr pointer is not empty when a bad token is given
mrampton
reviewed
Sep 6, 2023
cmd/sourceControl/github.go
Outdated
Comment on lines
15
to
28
| const ( | ||
| ghToken = "GH_TOKEN" | ||
| ghRepo = "GITHUB_REPOSITORY" | ||
| ghRefName = "GITHUB_REF_NAME" | ||
| ghActor = "GITHUB_ACTOR" | ||
| ghSha = "GITHUB_SHA" | ||
| ghEvent = "GITHUB_EVENT_NAME" | ||
| ghRef = "GITHUB_REF" | ||
| ghTriggeringActor = "GITHUB_TRIGGERING_ACTOR" | ||
| ghRefType = "GITHUB_REF_TYPE" | ||
| ghServer = "GITHUB_SERVER_URL" | ||
| ghRunId = "GITHUB_RUN_ID" | ||
| ghWorkflow = "GITHUB_WORKFLOW" | ||
| ) |
There was a problem hiding this comment.
These should all be available in deploy-engine:api -- but the names start as Github (so GithubToken, etc).
cmd/sourceControl/scm.go
Outdated
Comment on lines
25
to
33
| const ( | ||
| github de.Manager = "github" | ||
| bitbucket de.Manager = "bitbucket" | ||
| branch de.Reference = "branch" | ||
| tagRef de.Reference = "tag" | ||
| pullRequest de.Event = "pull_request" | ||
| push de.Event = "push" | ||
| workflowDispatch de.Event = "workflow_dispatch" | ||
| ) |
There was a problem hiding this comment.
These are likewise available in deploy-engine :)
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDAAS-2741
Move the logic for generating the information from the github action to the armory-cli
This change adds a Sim property to the request made to the deploy engine API so that work in Deploy engine will later saved and this information will be available for the PR lineage in the UI.
This was tested by running the armory client pointing to the remote-dev armory address using the new flag --with-scm. Using the goland debugging tools I was able to validate that the scmc data is being add to the request and the pipeline is triggered and deployed without issues