feat: route k8s requests with enqueueOne strategy to /pipelines endpoint #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qrnik
approved these changes
Oct 3, 2023
Greg-At-Armory
force-pushed
the
feat/cdaas-2801
branch
from
9495e66 to
a6e2fbd
Compare
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For deployments containing following configuration:
"deploymentConfig": { "ifDeploymentInProgress": { "strategy": "enqueueOne" } },if they are of type Kubernetes - route them to /pipelines endpoint, so they'd benefit of deployment queue functionality.
Motivation and Context
CDAAS-2801
How has this been tested? How can a reviewer test these changes?
added unit test, testes with staging deployment.
Have your performed the following tests?
Please confirm you have done the following tests to ensure your pull request is ready to be merged..
build/bin/darwin_amd64/armory deploy start -f <path to file>)?build/bin/darwin_amd64/armory login) and verified the credentials work?