Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: using our official image for armory cli deployment #196

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

Greg-At-Armory
Copy link
Contributor

Description

As per discussion with Justin - we should be using the official go-app base image for our go applications.
Base image adds all required certificates and registers them so we should have no issues connecting with this cli to our cluster. Also - all the user and dependency managment is handled by the base image!

Motivation and Context

CDAAS-2859

How has this been tested? How can a reviewer test these changes?

Have your performed the following tests?

Please confirm you have done the following tests to ensure your pull request is ready to be merged..

  • If this change modifies the deployment flow have triggered a deployment using this branch (i.e. build/bin/darwin_amd64/armory deploy start -f <path to file>)?
  • If this change modifes the login flow have you tried logging in and out with this branch (i.e. build/bin/darwin_amd64/armory login) and verified the credentials work?
  • Have you verified the specific change made in this PR?

@armory-cloud-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots (100.0% 100.0% reviewed)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@fieldju fieldju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, we can sanity check that everything is fine with our internal services before cutting release which pushes it out to the public

@Greg-At-Armory Greg-At-Armory merged commit 781995d into main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants