fix: check node state before udating #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: minhthong582000 <[email protected]>
minhthong582000
force-pushed
the
refactor/eks-update
branch
7 times, most recently
from
cdfbbcf to
bd81ab9
Compare
Signed-off-by: minhthong582000 <[email protected]>
minhthong582000
force-pushed
the
refactor/eks-update
branch
from
bd81ab9 to
9e854f8
Compare
|
Also there's a bit TOO Much refactoring all in one. SMALL prs with SMALLER changes is better. |
christosarvanitis
previously approved these changes
Sep 4, 2023
Signed-off-by: minhthong582000 <[email protected]>
minhthong582000
force-pushed
the
refactor/eks-update
branch
from
e1f97f1 to
307c130
Compare
christosarvanitis
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructured the code into separate packages to enhance maintainability.
The primary enhancement is adding a nodegroup state check before performing updates. The updated logic will be:
If the state is ACTIVE, initiate the update process and await its completion.
Then, the "eks-auto-updater" job will eventually be terminated as pods transition to a new nodegroup in response to the updates.
When it came back, verify the node state, which should now UPDATING. Just wait for the update to finish.