Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid skymap type #71

Closed
wants to merge 1 commit into from
Closed

Conversation

rpaladin
Copy link
Contributor

Currently, for this demo: https://armory3d.github.io/armory_examples_browser/#examples-particle_smoke

The demo blend's world skymap is unsupported. (Armory only supports type, Hosek / Wilkie.)

image

Because of this complication, this error is raised:

image

Simple solution, change the skymap type to the supported type.

image

@MoritzBrueckner
Copy link
Contributor

Armory only supports type, Hosek / Wilkie

Armory does support Nishita skies, see armory3d/armory#2149 and https://armory3d.github.io/armory_examples_browser/#examples-world_sun_direction. The warning in the node UI comes from Eevee which doesn't support it, and I don't think Armory can remove the warning as long as it's not selectable as a rendering engine (the warning goes away if you switch to Cycles for example).

I think the warning in the console (it's not an error btw) is happening because Nishita currently doesn't take the environment strength into account. The environmentStrength uniform is always added to the world shader if a sky texture is used and because of that it is also added to the shader data so that Iron knows what uniforms it needs to pass. But since it's not actually used in the shader, the shader compiler removes it and Kha then can't find it at runtime, resulting in this warning message. We should fix this in the world shader generation instead, Nishita should take the environment strength into account I think.

@rpaladin
Copy link
Contributor Author

Armory does support Nishita skies

My mistake. I must have been thinking of Preetham..
https://github.com/armory3d/armory/wiki/supported_nodes#texture

@rpaladin rpaladin closed this Jan 29, 2023
@rpaladin
Copy link
Contributor Author

rpaladin commented Jan 30, 2023

@MoritzBrueckner thanks for the review. I just want to clarify some inconsistancies on your part that I noticed after researching your suggestions.. (This doesn't mean you're wrong in the least by the way, I still believe you're correct.)

https://armory3d.github.io/armory_examples_browser/#examples-world_sun_direction.

That demo does not use Nishita it uses Hosek / Wilkie. 🙂 Even the world material is named after it.

image

environmentStrength uniform

Do you perhaps mean envmapStrength?

@MoritzBrueckner
Copy link
Contributor

The demo also uses Nishita skies, you can switch the scenes by using 1 and 2:

Example browser screenshot

Do you perhaps mean envmapStrength?

Oops yes, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants