Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added average speed and time in history section. #48

Merged
merged 5 commits into from
Oct 31, 2022

Conversation

alexsam29
Copy link
Contributor

This PR is intended to resolve #44.

I added avg time and speed to both history sections in the practice and profile pages.

Code Changes

  • Added new table below existing history table to display averages
  • In showHistory() added new table row element creation for the avg table.
  • Added new variables in showHistory() to calculate average times.
  • Simplified innerHTML string for the existing table with new variables.
  • Added additional CSS to match new table with the existing table.

@vercel
Copy link

vercel bot commented Oct 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
typing-test ✅ Ready (Inspect) Visit Preview Oct 30, 2022 at 7:50PM (UTC)

Copy link
Owner

@arpitghura arpitghura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the required change

index.js Outdated Show resolved Hide resolved
profile.js Outdated Show resolved Hide resolved
@arpitghura arpitghura added hacktoberfest issue under hacktoberfest hacktoberfest-accepted issue/PR accepted under hacktoberfest changes-requested changes requested labels Oct 30, 2022
@alexsam29
Copy link
Contributor Author

Do the required change

Sorry, I fixed it.

@arpitghura arpitghura merged commit 41dbda0 into arpitghura:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested changes requested hacktoberfest issue under hacktoberfest hacktoberfest-accepted issue/PR accepted under hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add average time and speed to history section
2 participants