Get our production builds to be usable #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're hitting dart-lang/sdk#39945, which prevents us from capturing log output and also spams the user with dozens of console boxes :-/ |
If a user enters a scary enough password we're up a creek because the bash script will error out. Instead, prompt them for a password via Zenity during the install process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Fix crash on resizeSeems to only be an assert, it sucks but there's no sane fix at the moment. Rolling Flutter tomasterbreaks basically every library right now - 🐛 Scrollbar This widget has been unmounted, so the State no longer has a context (and should be considered defunct). bdlukaa/fluent_ui#71