Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "second" and "day(s)" translation to Greek #1186

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Improve "second" and "day(s)" translation to Greek #1186

merged 1 commit into from
Aug 27, 2024

Conversation

pothitos
Copy link
Contributor

Pull Request Checklist

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

Description of Changes

Hello Jad and thanks for merging my previous pull request!

I finally migrated to this nice library and found another two improvements/fixes for the Greek translation (in accordance to humanize).

By the way, when do you plan to create a new PyPI package?

Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution.

@jadchaar jadchaar merged commit f77aa1d into arrow-py:master Aug 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants