Updated regular expressions, fixed a few bugs, added tests for v0.15.0 #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c format to use regex
… to inherit from value error
…g issue with ordinal dates
|
Note: tests seem to be passing, but we are still not at 100% coverage. |
systemcatch
reviewed
Aug 18, 2019
| # Before this, the ParserErrors were caught by the try/except in | ||
| # _parse_multiformat() and the appropriate error message was not | ||
| # transmitted to the user. | ||
| class ParserMatchError(ParserError): |
| has_minutes = colon_count == 1 or len(time_parts[0]) == 4 | ||
| has_seconds = colon_count == 2 or len(time_parts[0]) == 6 | ||
| has_subseconds = re.search("[.,]", time_parts[0]) | ||
| time_components = self._TIME_RE.match(time_parts[0]) |
There was a problem hiding this comment.
👏 regex to the rescue again!
| @@ -429,23 +441,23 @@ def _choice_re(choices, flags=0): | |||
|
|
|||
|
|
|||
| class TzinfoParser(object): | |||
|
|
|||
| _TZINFO_RE = re.compile(r"([+\-])?(\d\d):?(\d\d)?") | |||
| # TODO: test against full timezone DB | |||
systemcatch
reviewed
Aug 18, 2019
Codecov Report
@@ Coverage Diff @@
## Version-0.15.0 #639 +/- ##
=============================================
Coverage 100% 100%
=============================================
Files 8 8
Lines 1511 1507 -4
Branches 235 233 -2
=============================================
- Hits 1511 1507 -4
Continue to review full report at Codecov.
|
systemcatch
reviewed
Aug 19, 2019
systemcatch
reviewed
Aug 19, 2019
| self.assertEqual(self.parser.parse("01"), tz.tzoffset(None, 3600)) | ||
| self.assertEqual(self.parser.parse("+01"), tz.tzoffset(None, 3600)) | ||
| self.assertEqual(self.parser.parse("-01"), tz.tzoffset(None, -3600)) | ||
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xtoken can now properly parse float timestamp stringstzis present and will parse it accordingly (rather than going on the assumption that the logic defaults to UTC and ignores the Z, it is now more explicit with atzutcobject).ParserErrorexceptions that were thrown when theday_of_yearlogic encountered an error were not shown to the user because they were being prematurely caught. I fixed this by adding a newParserMatchErrorthat inherits fromParserErrorthat can be caught by the internal logic and allow theParserErrorsto propagate.ParserErrornow inherits fromValueError, which makes more sense then aRuntimeError.