Deprecate Python 2.7 and Python 3.5

[jadchaar]

Python 2.7 & 3.5 Deprecation Checklist

• Update setup.py classifiers and python_requires to declare arrow only supports Python 3.6+
• Drop Python < 3.6 from CI
• Remove Python < 3.6 from Makefile
• Run pyupgrade --py36-plus
• Convert all formatting to f-strings (should be done by pyupgrade)
• Remove all future imports
• Remove any remaining python 2 import shadowing
• Audit and overhaul requirements file
• Change timestamp formatting to use datetime.timestamp()
• Update timestamp calls in formatter.py
• Replace hardcoded MAX_TIMESTAMP constant with datetime.max.timestamp()
• Convert isinstance(value, numbers.Integral) to isinstance(value, int)
• Remove isstr function
• Remove __cmp__() method in arrow.py
• Remove coverage pragmas and skipped tests for py27
• Revisit enfold calls in code @systemcatch

Breaking changes for v1.0.0

• Change timestamp from property to method in arrow.py (requires deprecation warning beforehand)
• Change the return value of Arrow's timestamp method (currently a property) to a float

General Changes for v1.0.0

• Remove beta label from setup.py

Closes: #465
Closes: #861
Closes: #739

[codecov]

Codecov Report

Merging #877 (6fc80d9) into master (609b630) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #877   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         1810      1796   -14     
  Branches       312       313    +1     
=========================================
- Hits          1810      1796   -14     

Impacted Files	Coverage Δ
arrow/api.py	100.00% <ø> (ø)
arrow/arrow.py	100.00% <100.00%> (ø)
arrow/constants.py	100.00% <100.00%> (ø)
arrow/factory.py	100.00% <100.00%> (ø)
arrow/formatter.py	100.00% <100.00%> (ø)
arrow/locales.py	100.00% <100.00%> (ø)
arrow/parser.py	100.00% <100.00%> (ø)
arrow/util.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 609b630...6fc80d9. Read the comment docs.

[jadchaar]

Should be ready for review @systemcatch @krisfremen. All what remains is updating the enfold calls, which @systemcatch is more familiar with.

[systemcatch]

Hey @jadchaar just a few comments but otherwise it looks very solid.

The enfold calls aren't an issue on python 3.6+, I suggest we leave them for a later PR as the users won't see much difference.

[systemcatch]

Probably best to stick with old way to guarantee compatibility.

[jadchaar]

Thanks for the feedback. We had a note to revisit enfold in the copy constructor since we would now be able to just copy the datetime object as is rather than having to enfold again. Do we want to ignore that and just leave it for a future PR?

[systemcatch]

Thanks for the feedback. We had a note to revisit enfold in the copy constructor since we would now be able to just copy the datetime object as is rather than having to enfold again. Do we want to ignore that and just leave it for a future PR?

Not sure what you mean by copy constructor?

[jadchaar]

Oh oops sorry I meant replace:

arrow/arrow/arrow.py

Lines 777 to 823 in 609b630

	def replace(self, **kwargs):
	"""Returns a new :class:`Arrow <arrow.arrow.Arrow>` object with attributes updated
	according to inputs.
	Use property names to set their value absolutely::
	>>> import arrow
	>>> arw = arrow.utcnow()
	>>> arw
	<Arrow [2013-05-11T22:27:34.787885+00:00]>
	>>> arw.replace(year=2014, month=6)
	<Arrow [2014-06-11T22:27:34.787885+00:00]>
	You can also replace the timezone without conversion, using a
	:ref:`timezone expression <tz-expr>`::
	>>> arw.replace(tzinfo=tz.tzlocal())
	<Arrow [2013-05-11T22:27:34.787885-07:00]>
	"""
	absolute_kwargs = {}
	for key, value in kwargs.items():
	if key in self._ATTRS:
	absolute_kwargs[key] = value
	elif key in ["week", "quarter"]:
	raise AttributeError("setting absolute {} is not supported".format(key))
	elif key not in ["tzinfo", "fold"]:
	raise AttributeError('unknown attribute: "{}"'.format(key))
	current = self._datetime.replace(**absolute_kwargs)
	tzinfo = kwargs.get("tzinfo")
	if tzinfo is not None:
	tzinfo = self._get_tzinfo(tzinfo)
	current = current.replace(tzinfo=tzinfo)
	fold = kwargs.get("fold")
	# TODO revisit this once we drop support for 2.7/3.5
	if fold is not None:
	current = dateutil_tz.enfold(current, fold=fold)
	return self.fromdatetime(current)

We probably don't need enfold here anymore since datetime would replace fold natively. Thoughts?

[systemcatch]

You're right, how about I make an issue to update the enfold calls after 1.0.0 is released?

[jadchaar]

Ref: #878

Want to approve so we can get this merged @systemcatch?

[jadchaar]

@isac322 You should be good to now implement type checking off of master!