Skip to content

Commit

Permalink
using dedicated HTTP clients
Browse files Browse the repository at this point in the history
fixes kedacore#1133

Signed-off-by: Aaron Schlesinger <[email protected]>
  • Loading branch information
arschles committed Dec 4, 2020
1 parent fcc463b commit bc312d7
Show file tree
Hide file tree
Showing 126 changed files with 1,198 additions and 827 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Licensed under the MIT License. See https://go.microsoft.com/fwlink/?linkid=2090316 for license information.
#-------------------------------------------------------------------------------------------------------------

FROM golang:1.15.1
FROM golang:1.15.3

# Avoid warnings by switching to noninteractive
ENV DEBIAN_FRONTEND=noninteractive
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@

// Add the IDs of extensions you want installed when the container is created in the array below.
"extensions": [
"ms-vscode.go"
"golang.go"
]
}
5 changes: 4 additions & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
blank_issues_enabled: false
contact_links:
- name: Ask a question or get support
- name: Ask a question about KEDA or get support
url: https://github.com/kedacore/keda/discussions/new
about: Ask a question or request support for using KEDA
- name: Ask a question related to governance
url: https://github.com/kedacore/governance/discussions/new
about: Ask a question about the governance of KEDA
26 changes: 26 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
version: 2
updates:
- package-ecosystem: github-actions
directory: "/"
schedule:
interval: weekly
open-pull-requests-limit: 10
labels:
- enhancement
- dependency-management
- package-ecosystem: gomod
directory: "/"
schedule:
interval: weekly
open-pull-requests-limit: 10
labels:
- enhancement
- dependency-management
- package-ecosystem: docker
directory: "/"
schedule:
interval: weekly
open-pull-requests-limit: 10
labels:
- enhancement
- dependency-management
6 changes: 3 additions & 3 deletions .github/workflows/build-tools.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: build-tools CI
name: build-tools-CI
on:
push:
branches:
- master
- v2
- main
- v1
paths:
- 'tools/**'
jobs:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/fossa.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
name: FOSSA
on:
push:
branches: [master]
branches: [main]
pull_request:
branches: [master]
branches: [main]

jobs:
build:
runs-on: ubuntu-latest
# build-tools is built from ../../tools/build-tools.Dockerfile
container: kedacore/build-tools:latest
container: kedacore/build-tools:main
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v1
- uses: actions/setup-go@v2
with:
go-version: "^1.13.1"
go-version: "^1.15.5"
- run: go version
# Runs a set of commands to initialize and analyze with FOSSA
- name: run FOSSA analysis
Expand Down
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
name: master build
name: main-build
on:
push:
branches:
- master
- main
jobs:
validate:
name: Validate
runs-on: ubuntu-latest
# build-tools is built from ../../tools/build-tools.Dockerfile
container: kedacore/build-tools:latest
container: kedacore/build-tools:main
steps:
- name: Check out code
uses: actions/checkout@v1
with:
fetch-depth: 1

- name: Go modules cache
uses: actions/cache@v1
uses: actions/cache@v2.1.3
with:
path: /go/pkg
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/nightly-e2e.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: nightly e2e test
name: nightly-e2e-test
on:
schedule:
- cron: "0 0 * * *"
Expand All @@ -7,7 +7,7 @@ jobs:
name: Test
runs-on: ubuntu-latest
# build-tools is built from ../../tools/build-tools.Dockerfile
container: kedacore/build-tools:latest
container: kedacore/build-tools:main
steps:
- name: Check out code
uses: actions/checkout@v1
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/pr-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ jobs:
name: Validate PR
runs-on: ubuntu-latest
# build-tools is built from ../../tools/build-tools.Dockerfile
container: kedacore/build-tools:v2
container: kedacore/build-tools:main
steps:
- name: Check out code
uses: actions/checkout@v1
with:
fetch-depth: 1

- name: Go modules cache
uses: actions/cache@v1
uses: actions/cache@v2.1.3
with:
path: /go/pkg
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
Expand All @@ -36,14 +36,14 @@ jobs:
name: Static Checks
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v1
- uses: actions/setup-go@v2-beta
- uses: actions/checkout@v1
- uses: actions/setup-python@v2.1.4
- uses: actions/setup-go@v2
with:
go-version: 1.15.1
go-version: 1.15.5
- name: Get golangci
run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.31.0
- uses: pre-commit/action@v1.0.1
- uses: pre-commit/action@v2.0.0

codeScanning:
name: Code Scanning
Expand All @@ -57,7 +57,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v1
with:
# We must fetch at least the immediate parents so that if this is
# a pull request then we can checkout the head.
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/release-build.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: release build
name: release-build
on:
push:
tags:
Expand All @@ -8,15 +8,15 @@ jobs:
name: Push Release
runs-on: ubuntu-latest
# build-tools is built from ../../tools/build-tools.Dockerfile
container: kedacore/build-tools:latest
container: kedacore/build-tools:main
steps:
- name: Check out code
uses: actions/checkout@v1
with:
fetch-depth: 1

- name: Go modules cache
uses: actions/cache@v1
uses: actions/cache@v2.1.3
with:
path: /go/pkg
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
Expand All @@ -33,20 +33,20 @@ jobs:
id: get_version
run: echo ::set-output name=VERSION::${GITHUB_REF#refs/tags/v}

- name: Publish KEDA images to Docker Hub
run: make publish
- name: Release Deployment YAML file
run: make release
env:
VERSION: ${{ steps.get_version.outputs.VERSION }}

- name: Release Deployment YAML file
run: make release
- name: Publish KEDA images to Docker Hub
run: make publish
env:
VERSION: ${{ steps.get_version.outputs.VERSION }}

# Get release information to determine id of the current release
- name: Get Release
id: get-release-info
uses: bruceadams/[email protected].0
uses: bruceadams/[email protected].2
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
name: v2 build
name: v1-build
on:
push:
branches:
- v2
- v1
jobs:
validate:
name: Validate
runs-on: ubuntu-latest
# build-tools is built from ../../tools/build-tools.Dockerfile
container: kedacore/build-tools:v2
container: kedacore/build-tools:v1
steps:
- name: Check out code
uses: actions/checkout@v1
with:
fetch-depth: 1

- name: Go modules cache
uses: actions/cache@v1
uses: actions/cache@v2.1.3
with:
path: /go/pkg
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
Expand Down
8 changes: 4 additions & 4 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ linters:
- scopelint
- structcheck
- deadcode
#- depguard
#- dogsled
- depguard
- dogsled
#- errcheck
#- funlen
#- goconst
- goconst
#- gocritic
#- gocyclo
- gocyclo
- gosimple
- stylecheck
- unused
Expand Down
59 changes: 0 additions & 59 deletions BRANDING.md

This file was deleted.

2 changes: 1 addition & 1 deletion BUILD.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ make build

This project is using [Operator SDK framework](https://github.com/operator-framework/operator-sdk), make sure you
have installed the right version. To check the current version used for KEDA check the `RELEASE_VERSION` in file
[tools/build-tools.Dockerfile](https://github.com/kedacore/keda/blob/master/tools/build-tools.Dockerfile).
[tools/build-tools.Dockerfile](https://github.com/kedacore/keda/blob/main/tools/build-tools.Dockerfile).

```bash
git clone [email protected]:kedacore/keda.git
Expand Down
17 changes: 17 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

## History

- [Unreleased](#unreleased)
- [v2.0.0](#v200)
- [v1.5.0](#v150)
- [v1.4.1](#v141)
Expand All @@ -13,10 +14,25 @@
- [v1.1.0](#v110)
- [v1.0.0](#v100)

## Unreleased

### New
- Can use Pod Identity with Azure Event Hub scaler ([#994](https://github.com/kedacore/keda/issues/994))

### Improvements
- Support add ScaledJob's label to its job ([#1311](https://github.com/kedacore/keda/issues/1311))
- Bug fix in aws_iam_authorization to utilize correct secret from env key name ([PR #1332](https://github.com/kedacore/keda/pull/1332))

### Breaking Changes

### Other
- Bump go module version to v2 ([#1324](https://github.com/kedacore/keda/pull/1324))

## v2.0.0

### New

- KEDA uses a dedicated [HTTP client](https://pkg.go.dev/net/http#Client), connection pool, and (optional) TLS certificate for each configured scaler
- KEDA scales any CustomResource that implements Scale subresource ([#703](https://github.com/kedacore/keda/issues/703))
- Provide KEDA go-client ([#494](https://github.com/kedacore/keda/issues/494))
- Define KEDA readiness and liveness probes ([#788](https://github.com/kedacore/keda/issues/788))
Expand All @@ -43,6 +59,7 @@
- Added ScaledObject Status Conditions to display status of scaling ([#750](https://github.com/kedacore/keda/pull/750))
- Added optional authentication parameters for the Redis Scaler ([#962](https://github.com/kedacore/keda/pull/962))
- Improved GCP PubSub Scaler performance by closing the client correctly ([#1087](https://github.com/kedacore/keda/pull/1087))
- Added support for Trigger Authentication for GCP PubSub scaler ([#1291](https://github.com/kedacore/keda/pull/1291))

### Breaking Changes

Expand Down
Loading

0 comments on commit bc312d7

Please sign in to comment.