Add PHPStan code analysis [WEB-2017] #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgarwood
requested changes
Feb 4, 2025
.github/workflows/analyze.yml
Outdated
| - name: Install PHP dependencies | ||
| run: composer install --no-interaction --no-progress --no-scripts | ||
| - name: Run PHP CodeSniffer | ||
| run: ./vendor/bin/phpstan analyze --no-progress --no-interaction --no-ansi |
There was a problem hiding this comment.
The command requires a path:
./vendor/bin/phpstan analyze --no-progress --no-interaction --no-ansi ./some/pathThere was a problem hiding this comment.
The paths are set in the phpstan.neon config file. Passing a path in the command line here would override the paths set in the config, so I think it's better managed there.
composer.json
Outdated
| @@ -77,6 +77,7 @@ | |||
| "mockery/mockery": "^1.0", | |||
| "nunomaduro/collision": "^7.0", | |||
| "orchestra/testbench": "^7.8 || ^8.0 || ^9.0", | |||
| "phpstan/phpstan": "^1.12", | |||
There was a problem hiding this comment.
Can/should we install and configure PHPStan in the data-hub-foundation package, so we can use it in all of our projects?
There was a problem hiding this comment.
Yes! I moved PHPStan into the data-hub-foundation and created a composer script to invoke it.
nikhiltri
force-pushed
the
feature/phpstan
branch
from
da7dc8e to
dd54c6f
Compare
nikhiltri
force-pushed
the
feature/phpstan
branch
from
5745ae9 to
9194e51
Compare
|
nikhiltri
changed the title
nikhiltri
added a commit
that referenced
this pull request
Feb 6, 2025
Add PHPStan code analysis [WEB-2017]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.