Contain build artifacts to a pkg directory. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2022 15:03
In an effort to make the build process cleaner and not pollute the root directory with build artifacts, I have updated the build script to ensure that any build artifacts are places in a pkg directory. This allows easier understanding and easier cleanup.
|
Thank you very much! This does look handy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a great tool and I love using it! However it is also a great example of how to package a ruby app with mruby. So I spent time reverse engineering how you did it. In an effort to minimize the pollution of build artifacts in the root of the directory but also more selfishly to make this more reusable myself in other projects I changed the build process to contain the build artifacts in
pkg.I hope this is a helpful change!