Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Добавил возможность переопределить статус выполнения шага #148

Merged
merged 11 commits into from
Apr 4, 2019
Merged

Добавил возможность переопределить статус выполнения шага #148

merged 11 commits into from
Apr 4, 2019

Conversation

zeratulayuris
Copy link
Contributor

@zeratulayuris zeratulayuris commented Apr 3, 2019 •
edited by artbear
Loading

Реализация #121

zeratulayuris
zeratulayuris commented Apr 3, 2019
View reviewed changes
src/bdd-exec.os Outdated Show resolved Hide resolved
artbear
artbear requested changes Apr 3, 2019
View reviewed changes
Copy link
Owner

@artbear artbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отлично, что сделан полный приемочный тест.

У меня есть предложения по улучшению.
Что скажешь?

src/bdd-exec.os Outdated Show resolved Hide resolved
features/core/ВызовШагаСУстановкойСтатуса.feature Outdated Show resolved Hide resolved
src/bdd-exec.os Outdated Show resolved Hide resolved
@artbear artbear added this to the 1.8.0 milestone Apr 4, 2019
@artbear
Copy link
Owner

artbear commented Apr 4, 2019

@zeratulayuris Все работает, я слегка поправил файлы и названия в них.

Тесты зеленые.

Последнее сделаешь?
Добавишь доку на новый шаг в доку библиотечных шагов?

и затем я замержу

artbear
artbear approved these changes Apr 4, 2019
View reviewed changes
Copy link
Owner

@artbear artbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Круто и очень полезно.

@artbear artbear merged commit e82e5ca into artbear:develop Apr 4, 2019
This was referenced Apr 4, 2019
Closed
Closed
@zeratulayuris zeratulayuris deleted the skip-scenario branch April 5, 2019 05:02
@artbear artbear modified the milestones: 1.8.0, 1.10 Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artbear artbear artbear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@zeratulayuris @artbear