Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to AIS workflow #81

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Minor fixes to AIS workflow #81

merged 1 commit into from
Nov 15, 2024

Conversation

djjuhasz
Copy link
Contributor

@djjuhasz djjuhasz commented Nov 15, 2024

Refs #77.

  • Remove extraneous filepath.Join() calls
  • Improve commentary a bit
  • Correct "search_md" zip name in workflow tests

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.56%. Comparing base (fa37e42) to head (d2bc160).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/ais/combinemd.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   54.48%   61.56%   +7.08%     
==========================================
  Files          30       31       +1     
  Lines        1986     2084      +98     
==========================================
+ Hits         1082     1283     +201     
+ Misses        832      705     -127     
- Partials       72       96      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Refs #77.

- Remove extraneous `filepath.Join()` calls
- Improve commentary a bit
- Correct "search_md" zip name in workflow tests

[skip codecov]
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@djjuhasz djjuhasz merged commit 5d1dbbb into main Nov 15, 2024
7 checks passed
@djjuhasz djjuhasz deleted the dev/issue-77-fixes branch November 15, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants